Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(semantic, transformer): simplify FxIndexMap type aliases #7524

Merged
merged 1 commit into from
Nov 28, 2024
Merged

refactor(semantic, transformer): simplify FxIndexMap type aliases #7524

merged 1 commit into from
Nov 28, 2024
+10 −14

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 28, 2024 •
edited
Loading

Pure refactor. Simplify FxIndexMap type aliases by using rustc_hash's FxBuildHasher, instead of longhand BuildHasherDefault<FxHasher>.

@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@overlookmotel Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 28, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 28, 2024 11:39
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 28, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #7524 will not alter performance

Comparing 11-28-refactor_semantic_transformer_simplify_fxindexmap_type_aliases (d21448b) with main (169b8bf)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 28, 2024
@Boshen Graphite App
Copy link
Member

Boshen commented Nov 28, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 28, 6:43 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 28, 6:43 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 28, 7:07 AM EST: A user merged this pull request with the Graphite merge queue.

@overlookmotel
refactor(semantic, transformer): simplify FxIndexMap type aliases (#…
d21448b 
…7524)

Pure refactor. Simplify `FxIndexMap` type aliases by using `rustc_hash`'s `FxBuildHasher`, instead of longhand `BuildHasherDefault<FxHasher>`.
@Boshen Boshen force-pushed the 11-28-refactor_semantic_transformer_simplify_fxindexmap_type_aliases branch from fcde7e0 to d21448b Compare November 28, 2024 12:01
@graphite-app graphite-app bot merged commit d21448b into main Nov 28, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-28-refactor_semantic_transformer_simplify_fxindexmap_type_aliases branch November 28, 2024 12:07
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

@Boshen Boshen Awaiting requested review from Boshen Boshen is a code owner

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@overlookmotel @Boshen